refactor: stricter return types, tsconfig cleanup #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
changed the title
erunion
approved these changes
Apr 9, 2025
| import { escapeString } from '../../helpers/escape.js'; | ||
|
|
||
| export const convertType = (obj: any[] | any, indent?: string, lastIndent?: string): unknown => { | ||
| export const convertType = (obj: any[] | any, indent?: string, lastIndent?: string): string | 'null' => { |
Member
There was a problem hiding this comment.
why not just type this to string?
Member
Author
There was a problem hiding this comment.
i kinda like when return types explicitly mention a value that's likely to show up, in case a downstream function wants to act on that value accordingly. no strong preferences on this though
| "useUnknownInCatchVariables": false, | ||
|
|
||
| "strict": true | ||
| "verbatimModuleSyntax": true |
Member
There was a problem hiding this comment.
haven't seen this one before, what's it do?
Member
Author
There was a problem hiding this comment.
we should probably enable it everywhere we can. it ensures that type imports use import type SomeType and not import SomeType, which will help us with treeshaking. as always mr. pocock has a good write-up on the subject in his cheat sheet: https://www.totaltypescript.com/tsconfig-cheat-sheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rides the coattails of #271 with a few stricter return types and a little
tsconfig.jsoncleanup.